Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submissions: Use a plain table for listing pending submissions #17

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

ryelle
Copy link
Collaborator

@ryelle ryelle commented Nov 22, 2024

Fixes WordPress/wporg-main-2022#16 — This swaps the "pending list" with photo thumbnail with a plain table, no photo.

Screenshots

submission-page

On small screens, the default table behavior is to scroll. Does this work, or should I try to add some CSS to switch to a single-column display?

submissions-small

@ryelle ryelle requested a review from fcoveram November 22, 2024 16:58
@ryelle ryelle self-assigned this Nov 22, 2024
@fcoveram
Copy link

A single column sounds good to me.

I also notice that header in Inter is slightly bigger than its parent in Garamond. Is that because there is no font size defined for small breakpoints?

@ryelle
Copy link
Collaborator Author

ryelle commented Nov 25, 2024

I also notice that header in Inter is slightly bigger than its parent in Garamond. Is that because there is no font size defined for small breakpoints?

Yeah, it looks like that's the case. Though technically the h1 is bigger at 26px, than the h2 at 24px, but visually it does look smaller. Is there supposed to be a smaller font size here? Where is the font reference for the Inter style headings? All I see in the WordPress.org Design Library figma are the Garamond-style ones.

Screenshot 2024-11-25 at 11 36 13 AM

@ryelle
Copy link
Collaborator Author

ryelle commented Nov 25, 2024

@fcoveram For a single column, how's this?

Or maybe without the inner borders?

@fcoveram
Copy link

For the table style, I like the version without inner borders. And we could also remove the space between boxes to make it look like a single element (table).

Regarding text styles, I just created the ticket wporg-main-2022#522 requesting an update.

@ryelle ryelle force-pushed the try/submissions-pending-table branch from 808d403 to ddd44bc Compare November 26, 2024 16:27
@ryelle
Copy link
Collaborator Author

ryelle commented Nov 26, 2024

Okay, the table looks like this now:

@fcoveram
Copy link

That looks good to me. Thanks

@ryelle ryelle merged commit e1facd7 into trunk Nov 26, 2024
@ryelle ryelle deleted the try/submissions-pending-table branch November 26, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants