Remove noreferrer from Site Link and Site Meta List blocks.
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess the original decision was based on a practice suggesting that using "noopener noreferrer" together is a safe approach. That's probably why it was implemented as such. It seems like "noreferrer" could be safely removed here in the showcase, as I haven't seen URLs containing sensitive user information. |
adamwoodnz
reviewed
Oct 16, 2023
ndiego
changed the title
noreferrer from Site Link block.noreferrer from Site Link and Site Meta List blocks.
Ah, good catch. Just updated the PR to include that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250
Removed
noreferrerfrom the link in the Site Link and Site Meta List blocks per feedback in #234