Add workaround for reauth modal immediately closing in Firefox #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #180
This PR introduces the workaround mentioned on WordPress/gutenberg#40912, which is to add
shouldCloseOnClickOutside={ false }
to the modal component, stopping the focus event in the iframe from closing the modal.The downside is that clicking the modal background will not close the modal anymore, but the close button still works.
Testing
Ensure you use Firefox and other browsers.
To force the modal to popup on the TOTP screen you can modify the script.js condition to something like