CP-1928 Increase WebSocket integration test delays #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Current coverage is 99.51%
|
|
Have you tried increasing it less? Maybe to 150 or even 125 instead of doubling it? |
|
+1 |
jayudey-wf
changed the title
|
@jayudey-wf ready for merge |
1 task
|
QA Resource Approval: +10
Merging into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We are seeing some intermittent failures for the SockJS integration tests on our Travis CI builds.
Solution
Increase the delays in the WebSocket integration test suites. This isn't ideal since it increases the build time, but I've created an issue to do a full test audit for performance and optimization: #151.
Testing
Code Review
@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf
@sebastianmalysa-wf
@srinivasdhanwada-wf