Comment out references to undefined liquid templates #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated dependencies and version Fixed QA
costateixeira
approved these changes
Sep 21, 2024
There was a problem hiding this comment.
@ritikarawlani @litlfred do you want to merge? or should we?
sushi-config.yaml
Outdated
| name: SMART | ||
| id: smart.who.int.ig-empty | ||
| canonical: http://smart.who.int/ig-empty | ||
| name: SMARTIGEmpty |
There was a problem hiding this comment.
name should be IGEmpty , i don't think we've been including SMART in names
I also renamed SMARTBase to Base
There was a problem hiding this comment.
There was a problem hiding this comment.
@brynrhodes this needs to be fixed before we merge
ritikarawlani
approved these changes
Dec 2, 2024
|
@costateixeira do i need to do something here? it has conflicts with base branch. looks like this might have been the source of the QA error that you fixed for me yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.