Skip to content

Commit

Permalink
0.1.3
Browse files Browse the repository at this point in the history
  • Loading branch information
mona-shakiba committed Oct 11, 2024
1 parent e34cc38 commit ec654fa
Show file tree
Hide file tree
Showing 40 changed files with 249 additions and 52 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

namespace tool_brickfield\local\htmlchecker\common\checks;

use tool_brickfield\local\htmlchecker\common\brickfield_accessibility_tag_test;
use tool_brickfield\local\htmlchecker\common\brickfield_accessibility_test;

/**
* Brickfield accessibility HTML checker library.
Expand All @@ -28,11 +28,25 @@
* @copyright 2020 onward: Brickfield Education Labs, www.brickfield.ie
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class i_is_not_used extends brickfield_accessibility_tag_test {
class i_is_not_used extends brickfield_accessibility_test {

/** @var int The default severity code for this test. */
public $defaultseverity = \tool_brickfield\local\htmlchecker\brickfield_accessibility::BA_TEST_SEVERE;

/** @var string The tag this test will fire on. */
public $tag = 'i';

/**
* Check for any i elements and flag them as errors
* while allowing font awesome icons to be used.
*/
public function check(): void {
foreach ($this->get_all_elements('i') as $element) {
// Ensure this is not a font awesome icon with aria-hidden.
if (str_contains($element->getAttribute('class'), 'fa-') && $element->getAttribute('aria-hidden') === 'true') {
continue;
}
$this->add_report($element);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@

/**
* Class i_is_not_used_testcase
*
* @covers \tool_brickfield\local\htmlchecker\common\checks\i_is_not_used
*/
class i_is_not_used_test extends all_checks {
/** @var string Check type */
Expand Down Expand Up @@ -71,4 +73,13 @@ public function test_check(): void {
$results = $this->get_checker_results($this->htmlpass);
$this->assertEmpty($results);
}

/**
* Test for font awesome icon.
*/
public function test_fa_icon(): void {
$html = '<div><i class="fa fa-user"></i><i>Hello there</i><i class="fa fa-address-book" aria-hidden="true"></i></div>';
$results = $this->get_checker_results($html);
$this->assertCount(2, $results);
}
}
4 changes: 2 additions & 2 deletions course/templates/activitychooser.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,8 @@
role="tab"
aria-label="{{#str}} aria:recommendedtab, core_course {{/str}}"
aria-controls="recommended-{{uniqid}}"
aria-selected="false"
tabindex="-1"
aria-selected="{{#recommendedFirst}}true{{/recommendedFirst}}{{^recommendedFirst}}false{{/recommendedFirst}}"
tabindex="{{#recommendedFirst}}0{{/recommendedFirst}}{{^recommendedFirst}}-1{{/recommendedFirst}}"
>
{{#str}} recommended, core {{/str}}
</a>
Expand Down
32 changes: 32 additions & 0 deletions install/lang/sgs/langconfig.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?php
// This file is part of Moodle - https://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <https://www.gnu.org/licenses/>.

/**
* Automatically generated strings for Moodle installer
*
* Do not edit this file manually! It contains just a subset of strings
* needed during the very first steps of installation. This file was
* generated automatically by export-installer.php (which is part of AMOS
* {@link http://docs.moodle.org/dev/Languages/AMOS}) using the
* list of strings defined in /install/stringnames.txt.
*
* @package installer
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/

defined('MOODLE_INTERNAL') || die();

$string['thislanguage'] = 'Žemaitėškā';
2 changes: 1 addition & 1 deletion lib/amd/build/form-autocomplete.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/amd/build/form-autocomplete.min.js.map

Large diffs are not rendered by default.

9 changes: 7 additions & 2 deletions lib/amd/src/form-autocomplete.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ define([
'core/loadingicon',
'core/aria',
'core_form/changechecker',
'core/popper2',
], function(
$,
log,
Expand All @@ -38,7 +39,8 @@ define([
notification,
LoadingIcon,
Aria,
FormChangeChecker
FormChangeChecker,
Popper
) {
// Private functions and variables.
/** @var {Object} KEYS - List of keycode constants. */
Expand Down Expand Up @@ -526,7 +528,10 @@ define([

// Show it if it is hidden.
Aria.unhide(suggestionsElement.get());
suggestionsElement.show();
Popper.createPopper(inputElement[0], suggestionsElement[0], {
placement: 'bottom-start',
modifiers: [{name: 'flip', enabled: false}],
});

// For each option in the list, hide it if it doesn't match the query.
suggestionsElement.children().each(function(index, node) {
Expand Down
11 changes: 10 additions & 1 deletion lib/tests/behat/behat_navigation.php
Original file line number Diff line number Diff line change
Expand Up @@ -937,10 +937,12 @@ protected function resolve_core_page_instance_url(string $type, string $identifi
]);
}

// This next section handles page types starting with an activity name. For example:
// "forum activity" or "quiz activity editing".
$parts = explode(' ', $type);
if (count($parts) > 1) {
$modname = $parts[0];
if ($parts[1] === 'activity') {
$modname = $parts[0];
$cm = $this->get_cm_by_activity_name($modname, $identifier);

if (count($parts) == 2) {
Expand All @@ -962,6 +964,13 @@ protected function resolve_core_page_instance_url(string $type, string $identifi
// Permissions page.
return new moodle_url('/admin/roles/permissions.php', ['contextid' => $cm->context->id]);
}

} else if ($parts[1] === 'index' && count($parts) == 2) {
$courseid = $this->get_course_id($identifier);
if (!$courseid) {
throw $coursenotfoundexception;
}
return new moodle_url("/mod/$modname/index.php", ['id' => $courseid]);
}
}

Expand Down
2 changes: 1 addition & 1 deletion local/urise/lang/en/local_urise.php
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@

// Descriptionview.
$string['requirements'] = "Requirements";
$string['goals'] = "Goals";
$string['goals'] = "Objectives";
$string['coursecontent'] = "Content";
$string['coursemethods'] = "Methods";
$string['additionalinfo'] = "Additional information";
Expand Down
2 changes: 1 addition & 1 deletion local/urise/templates/component_search.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
<div class="wunderbyteTableSearch urise text-right align-bottom" style="display:inline-flex;">
<input class="search urise form-control" name="search-{{uniqueid}}" placeholder="{{#str}} search, local_urise {{/str}}">
<a role="button" class="btn btn-primary searchbutton gradienthover ml-2 d-flex justify-content-center
align-items-center">{{#str}} search, local_wunderbyte_table {{/str}}<i class="fa-solid fa-magnifying-glass ml-2"></i></a>
align-items-center"><span class="spanhidemobile mr-2">{{#str}} search, local_wunderbyte_table {{/str}}</span><i class="fa-solid fa-magnifying-glass"></i></a>
</div>
{{/search}}
2 changes: 1 addition & 1 deletion local/urise/templates/table_card_container.mustache
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
<div class="background d-flex justify-content-center align-items-center">
<div class="container mw-90 d-flex justify-content-center">
<div class="row mb-2 w-100 d-flex justify-content-center flex-column">
<h1 class="font-weight-light text-center mb-4 text-light">
<h1 class="lexa-h1 text-center mb-4 text-light">
{{#str}} searchheadertext, local_urise {{/str}}
</h1>
{{> local_urise/component_search }}
Expand Down
4 changes: 2 additions & 2 deletions local/urise/version.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'local_urise';
$plugin->release = '0.2.19';
$plugin->version = 2024100800;
$plugin->release = '0.2.20';
$plugin->version = 2024101100;
$plugin->requires = 2022041900; // Requires this Moodle version. Current: Moodle 4.0.0.
$plugin->maturity = MATURITY_STABLE;
$plugin->dependencies = [
Expand Down
8 changes: 4 additions & 4 deletions local/urise/vue3/tests/mocks/mockStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import { createStore } from 'vuex';
const mockState = {
view: 'default', // or any default state you want to set
strings: {
fromlearningtitel: 'Goal Title',
goalnameplaceholder: 'Enter Goal Name',
fromlearningdescription: 'Goal Description',
goalsubjectplaceholder: 'Enter Goal Description',
fromlearningtitel: 'Objectives Title',
goalnameplaceholder: 'Enter Objective Name',
fromlearningdescription: 'Objective Description',
goalsubjectplaceholder: 'Enter Objective Description',
},
learningpath: {
name: 'Testing',
Expand Down
4 changes: 2 additions & 2 deletions local/wb_news/version.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
defined('MOODLE_INTERNAL') || die();

$plugin->component = 'local_wb_news';
$plugin->release = '1.1.11';
$plugin->version = 2024100200; // The current module version (Date: YYYYMMDDXX).
$plugin->release = '1.1.12';
$plugin->version = 2024101100; // The current module version (Date: YYYYMMDDXX).
$plugin->requires = 2022041200; // Requires this Moodle version.
$plugin->maturity = MATURITY_ALPHA;
4 changes: 4 additions & 0 deletions local/wunderbyte_table/CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Version 2.0.21 (2024101100)
* Bugfix: Filter for json dataattributes
* Bugfix: Fallback empty calendar

## Version 2.0.20 (2024100900)
* Bugfix: Avoid pipe if no filter/searchtext is selected
* Bugfix: Fallback for empty data in event
Expand Down
Loading

0 comments on commit ec654fa

Please sign in to comment.