fix inf checks

Wunderbyte-GmbH · Jan 11, 2024 · 22fb936 · 22fb936
1 parent dbfa4cc
commit 22fb936
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/classes/teststrategy/preselect_task/addscalestandarderror.php b/classes/teststrategy/preselect_task/addscalestandarderror.php
@@ -181,14 +181,17 @@ protected function getplayedquestionsperscale(): array {
      * @return array
      */
     protected function getnumberofremainingquestionsperscale(): array {
+        $maxattemptsperscale = $this->context['max_attempts_per_scale'] === -1
+            ? INF
+            : $this->context['max_attempts_per_scale'];
         $pq = $this->getplayedquestionsperscale();
         $catscales = $this->get_with_child_scales($this->context['catscaleid']);
         foreach ($catscales as $scaleid) {
             if (!array_key_exists($scaleid, $pq)) {
-                $remainingperscale[$scaleid] = $this->context['max_attempts_per_scale'];
+                $remainingperscale[$scaleid] = $maxattemptsperscale;
                 continue;
             }
-            $remainingperscale[$scaleid] = $this->context['max_attempts_per_scale'] - count($pq[$scaleid]);
+            $remainingperscale[$scaleid] = $maxattemptsperscale - count($pq[$scaleid]);
         }
         return $remainingperscale;
     }

diff --git a/classes/teststrategy/preselect_task/mayberemovescale.php b/classes/teststrategy/preselect_task/mayberemovescale.php
@@ -62,7 +62,7 @@ public function run(array &$context, callable $next): result {
             );
         }
 
-        if ($context['max_attempts_per_scale'] == 0) {
+        if ($context['max_attempts_per_scale'] == -1) {
             return $next($context);
         }