GH-678 Remove reduntant description for missing result

If no specific scale can be identified, we already show a text with this information. In addition, there was a comment also providing information about why there is no result. To simplify and prevent confusion, the extra comments are removed.
Wunderbyte-GmbH · Oct 15, 2024 · 4879d85 · 4879d85
1 parent 2bb499f
commit 4879d85
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 40 deletions.
diff --git a/classes/teststrategy/feedbackgenerator/customscalefeedback.php b/classes/teststrategy/feedbackgenerator/customscalefeedback.php
@@ -99,18 +99,15 @@ public function get_studentfeedback(array $data): array {
             (array) $progress->get_quiz_settings(),
             $data['catscales']
         );
-        $firstelement = $data['customscalefeedback_abilities'][array_key_first($data['customscalefeedback_abilities'])];
-        $comment = $this->get_comment($firstelement);
 
         if (empty($customscalefeedback)) {
             return [];
-        } else {
-            return [
-                'heading' => $this->get_heading(),
-                'comment' => $comment,
-                'content' => $customscalefeedback,
-            ];
         }
+
+        return [
+            'heading' => $this->get_heading(),
+            'content' => $customscalefeedback,
+        ];
     }
 
     /**
@@ -339,33 +336,4 @@ private function getfeedbackforrange(int $catscaleid, int $groupnumber, array $q
 
         return $content;
     }
-
-    /**
-     * Get the comment line for the feedback
-     *
-     * @param array $firstelement
-     * @return string
-     */
-    private function get_comment(array $firstelement): string {
-        if (empty($firstelement['estimated'])) {
-            return "";
-        }
-
-        if (count($this->get_progress()->get_playedquestions()) === 0) {
-            return "";
-        }
-
-        if (!isset($firstelement['fraction'])) {
-            return get_string('estimatedbecause:default', 'local_catquiz');
-        }
-
-        switch ((int) $firstelement['fraction']) {
-            case 1:
-                return get_string('estimatedbecause:allanswerscorrect', 'local_catquiz');
-            case 0:
-                return get_string('estimatedbecause:allanswersincorrect', 'local_catquiz');
-        }
-
-        return get_string('estimatedbecause:default', 'local_catquiz');
-    }
 }
diff --git a/tests/teststrategy/feedbackgenerator/customscalefeedback_test.php b/tests/teststrategy/feedbackgenerator/customscalefeedback_test.php
@@ -132,7 +132,6 @@ public static function get_studentfeedback_provider(): array {
                     'expected' => [
                         'heading' => 'Feedback',
                         'content' => '<p dir="ltr" style="text-align: left;">adsfafs<\/p><br/>',
-                        'comment' => '',
                     ],
                 ],
                 'noscalestoreport' => [
@@ -173,10 +172,8 @@ public static function get_studentfeedback_provider(): array {
                     'expected' => [
                         'heading' => 'Feedback',
                         'content' => 'No valid feedback could be generated.',
-                        'comment' => '',
                     ],
                 ],
             ];
     }
-
 }