GH-220 clean code

Wunderbyte-GmbH · Jan 11, 2024 · d154497 · d154497
1 parent e5566af
commit d154497
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/classes/teststrategy/feedbackgenerator/personabilities.php b/classes/teststrategy/feedbackgenerator/personabilities.php
@@ -326,7 +326,9 @@ private function render_abilityprofile_chart(array $initialcontext, $primarycats
         $abilitysteps = [];
         $abilitystep = 0.25;
         $interval = $abilitystep * 2;
-        for ($i = LOCAL_CATQUIZ_PERSONABILITY_LOWER_LIMIT + $abilitystep; $i <= LOCAL_CATQUIZ_PERSONABILITY_UPPER_LIMIT - $abilitystep; $i += $interval) {
+        for ($i = LOCAL_CATQUIZ_PERSONABILITY_LOWER_LIMIT + $abilitystep;
+            $i <= LOCAL_CATQUIZ_PERSONABILITY_UPPER_LIMIT - $abilitystep;
+            $i += $interval) {
             $abilitysteps[] = $i;
         }
 
@@ -416,8 +418,8 @@ private function render_abilityprofile_chart(array $initialcontext, $primarycats
     private function round_to_customsteps(float $number, float $step, float $interval):float {
         $roundedvalue = round($number / $step) * $step;
 
-        // Exclude rounding to steps with 0.5
-        if ($roundedvalue - floor($roundedvalue) == 0.5) {
+        // Exclude rounding to steps defined in $interval.
+        if ($roundedvalue - floor($roundedvalue) == $interval) {
             $roundedvalue = floor($roundedvalue) + $step;
         }