Throw exception if catscale can not be found #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we lookup a catscale with a certain ID and there is none, raise an exception instead of returning null.
davidszkiba
force-pushed
the
dev-david-catscale-exception
branch
from
15177c8
to
c06df48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we lookup a catscale with a certain ID and there is none, raise an exception instead of returning null.
This prevents us from having to check if a catscale is null everytime we use the
return_catscale_object()function.Instead, the code that uses it can wrap the call within a try/catch block.
If we accidentally forget to do that, the exception message should make it easier to find the error.