Ralferlebach unit tests politome items #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidszkiba
force-pushed
the
ralferlebach-unit-tests-politome-items
branch
2 times, most recently
from
a91fe9d
to
eb4d2a1
Compare
* implement unit-tests for person ability: likelihood, 1st & 2nd derivate of log likelihood * implement helper methods for sanitizing, sorting, extracting fractions and getting keys * fixing all coding styles issunes of UNIT tests (moodle 4.4 requirements)
✘ Read item param from db with data set "grmgeneralized" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ 'difficulties' => Array (...) │ 'discrimination' => 5.92 │ - 'difficulty' => 0.59 │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ ✘ Read item param from db with data set "grm" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ 'difficulties' => Array (...) │ - 'difficulty' => 0.59 │ + 'discrimination' => 5.92 │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ ✘ Read item param from db with data set "pcmgeneralized" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ - 'difficulty' => 0.7 │ 'discrimination' => 2.1 │ 'intercepts' => Array (...) │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ ✘ Read item param from db with data set "pcm" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ - 'difficulty' => 0.68 │ 'intercepts' => Array (...) │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ strategy_test (local_catquiz\strategy_test) ✔ Import worked ✔ Import overrides with data set "update with simulation_beta.csv" ✘ Import csv with polytomous model │ │ Array to string conversion │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/teststrategy/strategy_test.php:188 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ model_item_param_test (local_catquiz\local\model\model_item_param_test) ✘ Read item param from db with data set "grmgeneralized" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ 'difficulties' => Array (...) │ 'discrimination' => 5.92 │ - 'difficulty' => 0.59 │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ ✘ Read item param from db with data set "grm" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ 'difficulties' => Array (...) │ - 'difficulty' => 0.59 │ + 'discrimination' => 5.92 │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ ✘ Read item param from db with data set "pcmgeneralized" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ - 'difficulty' => 0.7 │ 'discrimination' => 2.1 │ 'intercepts' => Array (...) │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ ✘ Read item param from db with data set "pcm" │ │ Failed asserting that two arrays are equal. │ --- Expected │ +++ Actual │ @@ @@ │ Array ( │ - 'difficulty' => 0.68 │ 'intercepts' => Array (...) │ ) │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/local/model/model_item_param_test.php:56 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │ strategy_test (local_catquiz\strategy_test) ✘ Import csv with polytomous model │ │ Array to string conversion │ │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/local/catquiz/tests/teststrategy/strategy_test.php:188 │ /home/runner/work/moodle-local_catquiz/moodle-local_catquiz/moodle/lib/phpunit/classes/advanced_testcase.php:72 │
davidszkiba
force-pushed
the
ralferlebach-unit-tests-politome-items
branch
from
d6e0de2
to
b4538b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.