Bugfix: Profile picture is destroyed by format_text so do not use it …

…in placeholders_info but only directly where we need it.

classes/booking_option.php

@@ -447,7 +447,9 @@ public function get_text_depending_on_status(booking_answers $bookinganswers, ?i
             }
         }
 
-        return placeholders_info::render_text($text, $this->settings->cmid, $this->settings->id, $userid);
+        $text = placeholders_info::render_text($text, $this->settings->cmid, $this->settings->id, $userid);
+
+        return format_text($text);
     }
 
     /**

classes/placeholders/placeholders_info.php

@@ -143,17 +143,16 @@ public static function render_text(
                 $text = str_replace($searchstring, $value, $text);
             }
         }
-
-        return format_text($text);
+        return $text;
     }
 
     /**
      * This builds an returns a list of localized placeholders.
      * They are stored statically and thus available throughout the ttl.
-     * @return array
+     * @return string
      * @throws coding_exception
      */
-    public static function return_list_of_placeholders() {
+    public static function return_list_of_placeholders(): string {
 
         // If it's already build, we can skip this.
         if (empty(self::$localizedplaceholders)) {