Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #162

Merged
merged 143 commits into from
May 15, 2024
Merged

Update #162

merged 143 commits into from
May 15, 2024

Conversation

linearcombination
Copy link
Contributor

Please see commits for what is in this pull request.

Sorry for the big PR. I was doing so great giving you smaller PRs, I will get back to that.

@linearcombination
Handle RTL languages
7d16c78 
Handle RTL languages even when mixed with LTR languages which is not
possible using only html dir directive, it is much more complicated
than that and we also implemented same for Docx which is handled
completely differently under the hood.
@linearcombination
Make mypy happy
24c17ea
@linearcombination
Displaay english language name too
e1d1ab1 
Displaay english language name in parens next to localized name. Note
that some languages have their localized name as, say,
Francais (French), when they should have only proided Francais as the
localized name. Because they did this you get
Francais (French) (French) as the outcome.
@linearcombination
Update 2023-08-09, see details below...
a043339 
* Implements #152
* Implements #154
* Implements #146
* Implements #156
* Fix #160
* Implements #158
* Fix #157
* Fix #159
@linearcombination
WIP
19869b6
@linearcombination
WIP Alternative layout approach, not quite there: no scrollbars, othe…
7f7e1d1 
…rwise good
@linearcombination
Basic layout sorted now
ad7cf57
@linearcombination
Starting to work out colors, shapes, and text
f37a109
@linearcombination
Starting work out dynamic behavior
5e34776
@linearcombination
Languages page mostly done
065dd81
@linearcombination
Pull out wizard breadcrumb into own component for reuse
57ae7a2
@linearcombination
Pull out wizard basket into its own component
ea8622d
@linearcombination
Make WizardBreadcrumb dynamics replace use of submit buttons
9bbee80 
And use WizardBreadcrumb and WizardBasket on books and resource_types screens
@linearcombination
Wizard improvements...
1003971 
* Add more dynamic behavior
* Use Wizard stuff in settings page
@linearcombination
Improved naming
2cd8a31
@linearcombination
Books page now works and is laid out properly
c9e671c
@linearcombination
Resource types page now works
ff25b1d
@linearcombination
Complete except inline error reporting on languages page
2fd2844
@linearcombination
Remove obsolete files and code
620f2bb
@linearcombination
Add frontend test for v2 ui
16d96de
@linearcombination linearcombination temporarily deployed to doc-dev.walink.org August 29, 2023 00:41 — with GitHub Actions Inactive
@linearcombination
Get necessary fonts for chinese into Docker image
929e01d
@linearcombination
Nicer language name presentations
ddf9663 
In translation.json a language has a localized name and its English
name. Unfortunately, many languages have included the English
name (usually in parens) in the slot designated for localized name
only. Further we display the English name next to the localized name
in the UI by requirement and so for those languages with this data
problem they end up having a name presentation like 'Foo (Bar) (Bar)'.
So this commit adds some logic to detect if the English name has been
erroneously included in the localized name and if it has it does not
add the English name in parens (since it is already there), otherwise
it does add the English name.
@linearcombination linearcombination temporarily deployed to doc-dev.walink.org September 1, 2023 23:42 — with GitHub Actions Inactive
@linearcombination linearcombination temporarily deployed to doc-dev.walink.org September 2, 2023 22:24 — with GitHub Actions Inactive
@linearcombination linearcombination temporarily deployed to doc-dev.walink.org September 3, 2023 00:03 — with GitHub Actions Inactive
@linearcombination
Add breadcrumb progress bar for mobile
84158d7 
To match figma design for mobile
@linearcombination
Update breadcrumb desktop step labels
5dcea03 
Make active state match figma by UX team request
@linearcombination
Warn user before they leave page while document generates
4136f3f 
They can still navigate away from page and lose state by clicking
links that go elsewhere. A future update may prevent or warn on that
as well.
@linearcombination
Document generation state now survives navigation
4aeb1b5 
This update allows the user to navigate within-app away from the
document generation page and return without losing the document
generation task status state. Further, if the user tries to reload or
close the tab while a document is being generated, the user is
presented with a system dialog asking if them to confirm their intent
or cancel the reload/close action.
@linearcombination
Fix bug
ab057bf
@linearcombination
Increase min text size to 20px
f8a86ef 
By request of UX team
@linearcombination
Use @apply to simplify some code
cc6374e 
Also adjust the search input field for languages and books to have a
little left margin
@linearcombination
Get rid of log message
4867f8e
@linearcombination
Fully working sveltkit-based update
eeb0189 
* Handle transfer URLs from BIEL with fully populated UI state
* New (required) env var name changes for sveltekit env var system
* Nginx config is now separate from node config and envvars js hack is
no longer needed because sveltekit handles this with the new env var system
@linearcombination
Minor update to docs
77818a1
@PurpleGuitar PurpleGuitar temporarily deployed to doc-dev.walink.org May 13, 2024 15:54 — with GitHub Actions Inactive
@PurpleGuitar PurpleGuitar merged commit 77818a1 into doc.bibleineverylanguage.org May 15, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PurpleGuitar PurpleGuitar PurpleGuitar approved these changes

@danparisd danparisd Awaiting requested review from danparisd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@linearcombination @PurpleGuitar @danparisd