Palette fixes #199
Merged
Palette fixes #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is comprised of two changes:
Temporarily force light mode all the time by setting theme options to
["light"]. This prevents dark mode from being activated, even if the user's desktop is in dark mode, because only some elements were in dark mode, and checkboxes looked checked even when they were not checked. (See image below for how the UI looked before the change.)Temporarily remove "text-primary-content" class from resource list. In light theme mode, it caused the resources to be a faint blue, hard to read. (See image below for how the UI looked before the change.)
Now light mode is always active, checkboxes look normal, and the resource text is easy to read. (See image below for how the UI looks now.)