Fix docx book repeat issue #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug wherein when two books were chosen the resulting document would only include one of the books twice. This commit fixes that and adds an end to end test.
One test is failing on github actions server for some unknown reason while it tests fine locally. github actions server environment seems to have more issues than anywhere else.
Still failed on github actions, so change it back. In next commit we will skip this test for github actions sake since it passes elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug wherein when two books were chosen the resulting docx (only happened in docx) document would only include one of the books twice. This commit fixes that and adds an end to end test.