Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated verse issue #224

Merged

Conversation

linearcombination
Copy link
Contributor

Translation Services noted that when rendering the document for English -> Kubu (kvb), some target text verses are repeated.

This was the classic "in a loop not using old value since current value is null". Fixed, as always, with freshly initializing value with empty string so that the value established in the last loop iteration is not used. Why were some verses null? Because the target language, in this case, did not have a particular book or verse available.

Translation Services noted that when rendering the document for
English -> Kubu (kvb), some target text verses are repeated.

This was the classic "in a loop not using old value since current
value is null". Fixed, as always, with freshly initializing value with
empty string so that the value established in the last loop iteration
is not used. Why were some verses null? Because the target language,
in this case, did not have a particular book or verse available.
@linearcombination linearcombination merged commit aa54d39 into doc-dev.walink.org Oct 17, 2024
13 checks passed
@linearcombination linearcombination deleted the fix-repeated-verse-for-some-languages branch October 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant