Update nov 4 2024 #230
Merged
Update nov 4 2024 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include name of document created
Let's only search for what we actually need so that we don't accidentally involve files that are extraneous to our purposes and which may introduce errors, e.g., bi, mrk, 2pe, .tstudio file in non-utf caused blow up of DOC and thus impacted STET also.
… DOC We were using nationalized book name in STET and really should be doing so in DOC also. While adding that also simplified doc assembly logic to get slightly better asymptotics and make code easier to follow.
Make sure an important (previously random) test, marked "all" in pytest, don't accidentally pick language, book, resource types that do not exist causing false test failures.
Logs too noisy
Perhaps unnecessary, but won't hurt.
No errors would probably ever occur because of this, but it is good hygiene.
There were a couple bugs in STET which caused source and target verse references to not match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.