Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return WMarker Term from preprocess #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsarabia
Copy link
Contributor

@jsarabia jsarabia commented Jul 5, 2024

Returning Term from preprocess allows for the word within a WMarker to be left as remaining text, which will then get picked up into a TextBlock.

If this is not done, the word within a WMarker would be ignored when doing something such as getting all TextBlocks from a VMarker, which seems a sensible way to get scripture text without markup from a verse.

Returning Term from preprocess allows for the word within a WMarker to be left as remaining text, which will then get picked up into a TextBlock. 

If this is not done, the word within a WMarker would be ignored when doing something such as getting all TextBlocks from a VMarker, which seems a sensible way to get scripture text without markup from a verse.
@@ -43,7 +43,7 @@ public override string PreProcess(string input)

}

return string.Empty;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would also need to add TextBlock to allowed markers in order for this to work as expected, otherwise we have a WMarker with the word set and then a text block following it, we would want this to contain that text block. Also if we go down this route I don't think we want to include an attribute for term here, there are others that we do this with we would want to handle those also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants