Check associated resource metadatas before restoring previously selected one #509
Conversation
| @@ -28,6 +28,11 @@ class ChapterTabGroup : TabGroup() { | |||
| tabMap.clear() | |||
| } | |||
|
|
|||
| private fun shouldRestoreActiveResourceMetadata(metadataToRestore: ResourceMetadata?): Boolean { | |||
| return metadataToRestore != null | |||
| && getAssociatedMetadatas().toList().contains(metadataToRestore) | |||
There was a problem hiding this comment.
Can probably do this on the sequence without building a list with toList (but the method might not be contains).
There was a problem hiding this comment.
Actually contains is a method of a sequence- my code completion took too long to load and only loaded a few methods so I thought it didn't exist!
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SarabiaJ)
src/main/kotlin/org/wycliffeassociates/otter/jvm/app/ui/chromeablestage/tabgroups/ChapterTabGroup.kt, line 33 at r1 (raw file):
Previously, KJoslyn wrote…
Actually
containsis a method of a sequence- my code completion took too long to load and only loaded a few methods so I thought it didn't exist!
LGTM
Corresponds to OT-22
This change is