Fix various instances of d43 links #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is currently marked as a draft because I would like some other eyes to look over this before I'm confident that I've accurately addressed all possible use cases of the code I changed. There are several different links that could be passed into the regex I've written or edited. The tests run and pass. I'd like to make sure I don't need any other tests, I didn't miss any edge cases, etc. |
…dit and understand
| @@ -0,0 +1,26 @@ | |||
| [ | |||
There was a problem hiding this comment.
I love this! Excellent use of data-driven test design.
PurpleGuitar
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses various places where the code is linking to door43 sites. These need to be replaced with links pointing to WACS. Several bits of regex are updated along with some other links.