exclude items not in main map area during processing #9
Conversation
* Detection Run, first entries * Adding more Detection Runs. * Add even more runs * Update/fix beta Nesaak * Update/fix prod-westgavel1-aar360.csv * Add more runs * More updates * Add more * Rename prefix to lower case * Process fresh data Co-authored-by: Magnus Ihse Bursie <[email protected]>
|
The currently issue that I have observed is that some locations are inaccurate, one example being NPC information on personal islands (aka, out of main map)
This information will likely differ for almost everyone, and I feel that performing the filtering client-side is pointless because the information is inaccurate to begin with. Generally, I think that NPCs outside of the main map are inaccurate, and given that eventually the map would not display if you are outside the main map area (for Artemis), there is no point for this data to be given to the client too. However, it is possible to just filter NPC locations of NPCs with coords above 60000 (ie. Personal Island NPCs only), what do you think? |
|
Actually, the plan is for the map to display outside the main area. NPCs outside the main map area should not be any less accurate, what makes you think that? I do however agree that personal islands is a special case, and should be removed. Are all personal island coordinates above [60000,60000], and conversely, is it only personal islands that are above [60000,60000]? |
|
I think what I said is more of a generalisation; I just had a thought of it and only just realised that Quest NPCs are included in the data, so my bad. Unrelated to this PR tho, I do think that there may not be a point to display a map outside of the main area in most circumstances because most of the time the points are underground, and thus the minimap will be pretty useless (correct me if I'm wrong, I think cave maps are not allowed on Wynncraft) as they're just going to show the roof of structures. That being said, it may be possible (albeit I feel alot of work is needed) to display only if the out-of-main-map structure is aboveground where the minimap could be useful As for the personal island one, that is per my observation, I'm not really sure honestly, but given that my personal island clearly did appear at the same coordinates as the island of the person who provided the data, I think it should be above [60000,60000]. So for your question "Are all and only personal islands located above [60000,60000]", I think that we need to figure out the answer first before making a decision. |
|
Cave maps are not allowed, that is correct, but there are many quests that teleport you to outdoor areas outside the main map. It is my intention to add these maps to Wynntils Artemis. This was not possible in Legacy due to limitations in the map code, but will be a no-brainer in Artemis. (In fact, maybe I should start mapping a few such areas just as proof of concept... Hmm...) Even in case of underground situations, showing e.g. the location of a NPC on an otherwise black map would be helpful. I might have an exceptionally bad sense of direction, but I've been struggling more than once to get back to some NPC character to report my findings, when they are hiding in some corner of an off-the-main-map cave. As for the personal island, I think they change coordinates when you relocate it do different cities. I guess we'd need to check the coordinates for all those possible locations. |
No description provided.