forked from mdn/content
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mdn. patch 1 #1
Merged
Merged
Mdn. patch 1 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) updated Intl.DateTimeFormat constructor to clarify that hourCycle: `h11` option will allow dayPeriod to be shown Previous wording implied that dayPeriod is only used if `(hourCycle: 'h12')` option is set, updated to reflect that `dayPeriod` is displayed if either `{hourCycle: 'h12'` or `(hourCycle: 'h11')` are set. See below: ```const date = new Date(Date.UTC(2020, 11, 20, 18, 23, 16, 738)); // Results below assume UTC timezone - your results may vary console.log(new Intl.DateTimeFormat('en-US', {hourCycle: 'h11', hour: '2-digit', dayPeriod: 'long'}).format(date)) console.log(new Intl.DateTimeFormat('en-US', {hourCycle: 'h12', hour: '2-digit', dayPeriod: 'long'}).format(date)) console.log(new Intl.DateTimeFormat('en-US', {hourCycle: 'h23', hour: '2-digit', dayPeriod: 'long'}).format(date)) console.log(new Intl.DateTimeFormat('en-US', {hourCycle: 'h24', hour: '2-digit', dayPeriod: 'long'}).format(date)) // output: // > "10 in the morning" // > "10 in the morning" // > "10" // > "10"```
* Add reference for ISO 8859-1 * Update files/en-us/web/javascript/guide/grammar_and_types/index.md --------- Co-authored-by: Joshua Chen <[email protected]>
* Update index.md * Update files/en-us/webassembly/understanding_the_text_format/index.md * Update files/en-us/webassembly/understanding_the_text_format/index.md Co-authored-by: Joshua Chen <[email protected]> * Update files/en-us/webassembly/understanding_the_text_format/index.md Co-authored-by: Hamish Willee <[email protected]> --------- Co-authored-by: Joshua Chen <[email protected]> Co-authored-by: Hamish Willee <[email protected]>
* Avoid double colon I moved the list after the colon to avoid using two colons in one sentence. * Clarify thought by separating extra info * "Microsoft Store App" → "Microsoft Store" To me, "Store App" feels like a typo, even though it may not be. * Add missing "by" * Make list spacing consistent * Add missing linking words between clauses * Remove apostrophe My gut feeling says the folder isn't owned by the applications—but I could be wrong. * Remove extra 'if' * Remove extra 's' * Use "through" instead of "thru" * Add link to what localStorage is * Update files/en-us/web/progressive_web_apps/tutorials/cycletracker/index.md * Update files/en-us/web/progressive_web_apps/tutorials/cycletracker/index.md --------- Co-authored-by: Hamish Willee <[email protected]>
fix typos
remove redundant "AKA"
…#28088) * Add 'constituent properties' section to all shorthand properties * Update files/en-us/web/css/overscroll-behavior/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Move and edit description --------- Co-authored-by: Dipika Bhattacharya <[email protected]>
* Update WebOTP API docs * Making fixes for comments from agektmr and yi-gu * Separate out WebAuthn combine advice into a note * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Eiji Kitamura <[email protected]> * Tweak WebAuthn note, and move it up to main concepts section * tweak wording again * include specific security concerns section * Update files/en-us/web/api/credentialscontainer/get/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/credentialscontainer/get/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/credentialscontainer/get/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/credentialscontainer/get/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/credentialscontainer/get/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/otpcredential/code/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/otpcredential/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Update files/en-us/web/api/webotp_api/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> * Make fixes for dipikabh comments --------- Co-authored-by: Eiji Kitamura <[email protected]> Co-authored-by: Dipika Bhattacharya <[email protected]>
This is pretty non-obvious, but it's mentioned in the spec: https://www.w3.org/TR/css-shapes/#security
…28105) * Hint to use `addEventListener` instead of the onchange property The onchange is a global and if multiple libraries use it, they will override each other, it's better to recommend the use of `addEventListener` (which is not documented on the linked page) * Update events to use reference to addEventListener like other pages instead of just `onchange` * Redirect onchange to #events * Add event documentation on subpage * Fix references to Idle * Fix reference to change event * Fix link texts * Remove wrong headers Co-authored-by: wbamberg <[email protected]> * Update files/en-us/web/api/screenorientation/change_event/index.md Co-authored-by: wbamberg <[email protected]> * Update files/en-us/web/api/screenorientation/change_event/index.md Co-authored-by: wbamberg <[email protected]> * Update files/en-us/web/api/screenorientation/index.md Co-authored-by: wbamberg <[email protected]> * Update files/en-us/web/api/screenorientation/index.md Co-authored-by: wbamberg <[email protected]> * Update files/en-us/web/api/window/orientationchange_event/index.md Co-authored-by: wbamberg <[email protected]> * Update files/en-us/web/api/screenorientation/change_event/index.md --------- Co-authored-by: wbamberg <[email protected]>
- edits a runon sentence - edits some punctuation - suggests consolidating the examples for name order
…#28155) * Fix broken example on feConvolveMatrix The example uses deprecated "xlink:href", so the image is not shown (at least in Firefox). Changing to just "href" fixes the issue. * Fix broken example on feBlend Example uses deprecated "xlink:href", which does not display the linked image on Firefox. Changing to just "href" fixes the issue.
…#27950) * relnote(116): SVG q unit supported (defined in CSS length units) * relnote(116): revert SVG type formatting * Update files/en-us/mozilla/firefox/releases/116/index.md Co-authored-by: Hamish Willee <[email protected]> * Update files/en-us/web/svg/content_type/index.md * relnote(116): clarify SVG2 and SVG1.1 case sensitivity --------- Co-authored-by: Hamish Willee <[email protected]>
* Add DevTools data for 116 release notes * Update files/en-us/mozilla/firefox/releases/116/index.md Co-authored-by: Brian Thomas Smith <[email protected]> --------- Co-authored-by: Brian Thomas Smith <[email protected]>
Fix 13024: remove TODO
* Fix issue 28318: Link to last article * Update files/en-us/learn/javascript/asynchronous/promises/index.md Co-authored-by: Dipika Bhattacharya <[email protected]> --------- Co-authored-by: Dipika Bhattacharya <[email protected]>
Update index.md Have start() method link point to the AudioBufferSourceNode specific page
mdn#28329) Update content/files/en-us/web/javascript/reference/functions/set/index.md
* Remove reviewdog.yml * Update CONTIRBUTING.md file
…#28306) followed the markdownlint/prettier ordering defined in the package.json fix:md and lint:md commands also update `markdownlint-cli2-fix` command to `markdownlint-cli2 --fix` see: https://github.com/okonet/lint-staged#task-concurrency follow-up to: mdn#27936 --------- Co-authored-by: Onkar Ruikar <[email protected]>
…mdn#27440) * Add OPFS standalone article * Multiple small improvements to OPFS-related reference docs * Update files/en-us/web/api/file_system_access_api/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/file_system_access_api/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/file_system_access_api/origin_private_file_system/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/filesystemsyncaccesshandle/write/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/file_system_access_api/origin_private_file_system/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/filesystemwritablefilestream/seek/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/filesystemwritablefilestream/truncate/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/file_system_access_api/origin_private_file_system/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/file_system_access_api/origin_private_file_system/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/file_system_access_api/origin_private_file_system/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/file_system_access_api/origin_private_file_system/index.md Co-authored-by: Thomas Steiner <[email protected]> * Update files/en-us/web/api/filesystemsyncaccesshandle/index.md Co-authored-by: Thomas Steiner <[email protected]> * Change File System Access API to File System API * Fix a couple more broken links * More broken link fixes * small assorted updates * Fixes made for Rumyra comments --------- Co-authored-by: Thomas Steiner <[email protected]>
Co-authored-by: Brian Thomas Smith <[email protected]>
* Set code languages for various files (part 1) * Revert LaTeX change for now * Update files/en-us/web/api/performance_api/server_timing/index.md Co-authored-by: Brian Thomas Smith <[email protected]> * Update files/en-us/learn/javascript/building_blocks/conditionals/index.md Co-authored-by: Joshua Chen <[email protected]> * Update files/en-us/learn/javascript/first_steps/variables/index.md Co-authored-by: Joshua Chen <[email protected]> * Fix selected languages * Fix selected languages * Fix selected languages * Apply suggestions from code review Co-authored-by: Joshua Chen <[email protected]> --------- Co-authored-by: Brian Thomas Smith <[email protected]> Co-authored-by: Joshua Chen <[email protected]>
Update index.md A code improvement. The constant that named the updated book in the process didn't had a name that was descriptive enough.
* LockManager return value description fixed. Fixes mdn#28339 * formatting --------- Co-authored-by: wbamberg <[email protected]>
* Update WAI-ARIA link from 1.1 to 1.2 * Update to version agnostic WAI-ARIA link
* change https requirement to secure context to improve consistency with other mdn pages * Apply suggestions from code review --------- Co-authored-by: Estelle Weyl <[email protected]> Co-authored-by: Estelle Weyl <[email protected]>
Run & review this pull request in StackBlitz Codeflow. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Additional details
Related issues and pull requests