Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add content for Staking API Section #29

Merged
merged 6 commits into from
Apr 9, 2024
Merged

docs: add content for Staking API Section #29

merged 6 commits into from
Apr 9, 2024

Conversation

HoangVD2
Copy link
Member

@HoangVD2 HoangVD2 commented Apr 4, 2024

@netlify Netlify
Copy link

netlify bot commented Apr 4, 2024 •
edited
Loading

✅ Deploy Preview for xdefidocs ready!

Name Link
🔨 Latest commit aa12c51
🔍 Latest deploy log https://app.netlify.com/sites/xdefidocs/deploys/6613cae4a4515500081b8c12
😎 Deploy Preview https://deploy-preview-29--xdefidocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-09 01:56 UTC

kourosh-rezaee
kourosh-rezaee approved these changes Apr 4, 2024
View reviewed changes
Copy link

@kourosh-rezaee kourosh-rezaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but in near future might change since the project is in WIP

davidp94
davidp94 requested changes Apr 4, 2024
View reviewed changes
staking/staking-api.md Outdated Show resolved Hide resolved
staking/staking-api.md Outdated Show resolved Hide resolved
staking/staking-api.md Outdated Show resolved Hide resolved
staking/staking-api.md Show resolved Hide resolved
staking/staking-api.md Outdated Show resolved Hide resolved
staking/staking-api.md Show resolved Hide resolved
staking/staking-api.md Outdated Show resolved Hide resolved
staking/staking-api.md Outdated Show resolved Hide resolved
staking/staking-api.md Outdated Show resolved Hide resolved
staking/staking-api.md Outdated Show resolved Hide resolved
davidp94
davidp94 requested changes Apr 4, 2024
View reviewed changes
staking/staking-api.md
:::

<div ref="refCreateStrideLiquidStakingTx" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tell the developer how he can then sign and broadcast the staking transaction (using cosmjs for cosmos, using XDEFI Wallet API, and then using ethersjs for EVM transactinos)

staking/staking-api.md
:::

<div ref="refCreateNativeStakingTx" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tell the developer how he can then sign and broadcast the staking transaction (using cosmjs for cosmos, using XDEFI Wallet API, and then using ethersjs for EVM transactinos)

staking/staking-api.md
:::

<div ref="refCreateLidoStakeTx" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tell the developer how he can then sign and broadcast the staking transaction (using cosmjs for cosmos, using XDEFI Wallet API, and then using ethersjs for EVM transactinos)

staking/staking-api.md
:::

<div ref="refCreateErc20ApproveTx" />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to tell the developer how he can then sign and broadcast the staking transaction (using cosmjs for cosmos, using XDEFI Wallet API, and then using ethersjs for EVM transactinos)

@HoangVD2 HoangVD2 requested a review from davidp94 April 5, 2024 02:59
davidp94
davidp94 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@davidp94 davidp94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can merge and create another PR for the client-side integration code for staking API.

@kourosh-rezaee
Copy link

i have added the descriptions on how the integrations should be in

@HoangVD2 HoangVD2 merged commit 6c4b4e5 into main Apr 9, 2024
5 checks passed
@HoangVD2 HoangVD2 deleted the docs/xdefi-6910 branch April 9, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kourosh-rezaee kourosh-rezaee kourosh-rezaee approved these changes

@davidp94 davidp94 davidp94 approved these changes

@0xnabil 0xnabil Awaiting requested review from 0xnabil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HoangVD2 @kourosh-rezaee @davidp94