Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Google Analytics and GSA DAP to preconnect loading #109

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

curt-mitch-census
Copy link
Member

@curt-mitch-census curt-mitch-census commented Apr 16, 2024

Pull Request

Description

Sets analytics scripts (Google Analytics and GSA's Digital Analytics Program) to preconnect to load earlier in page build process. Addresses: https://developer.chrome.com/docs/lighthouse/performance/uses-rel-preconnect/.

Also removes the no-longer-maintained jekyll-assets gem as its rack dependency has multiple Dependabot alerts: https://github.com/XDgov/xd.gov/security/dependabot.

Related Issue

Changes Made

  • Change script loads in head tag.
  • Removes jekyll-assets gem and its dependencies

Screenshots (if applicable)

N/A

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the project's coding standards.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • The title of my pull request is a short description of the changes.
  • My pull request is assigned to the appropriate milestone.

@curt-mitch-census curt-mitch-census merged commit f0781fd into master Apr 16, 2024
5 checks passed
@curt-mitch-census curt-mitch-census deleted the preconnect-setting branch April 16, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant