Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert GSA DAP to script instead of preconnect link #113

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Revert GSA DAP to script instead of preconnect link #113

merged 4 commits into from
Jun 5, 2024

Conversation

curt-mitch-census
Copy link
Member

Pull Request

Description

Reverts GSA DAP script to load as a script instead of a link with a preconnect setting.

Related Issue

N/A

Changes Made

Change GSA DAP loading from link to script element

Screenshots (if applicable)

Include screenshots or GIFs that demonstrate the changes, if relevant.

Checklist

  • I have read the CONTRIBUTING.md document.
  • My code follows the project's coding standards.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.
  • I have updated the documentation accordingly.
  • The title of my pull request is a short description of the changes.
  • My pull request is assigned to the appropriate milestone.

Additional Notes

Reference: https://github.com/digital-analytics-program/gov-wide-code/blob/master/documentation/GSA%20DAP%204.1%20-%20Quick%20Guide.pdf

@curt-mitch-census curt-mitch-census added the compliance compliance requirement label Jun 5, 2024
@curt-mitch-census curt-mitch-census merged commit fdff09c into master Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compliance compliance requirement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@curt-mitch-census