SR2 CS2AreaFractionTopExtended update #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated SR2 cut definition after update of preselection and added a 98% target acceptance version. See xenon:xenon1t:analysis:sciencerun2:cs2_aft_presel_update for more details.
JelleAalbers
approved these changes
Aug 31, 2019
There was a problem hiding this comment.
Thanks Dominick, looks good! The rejection power is way better now. I would recommend just using the 98% version, but this is probably up to you and the low-ER and X1T coordinators (e.g. @ershockley, @jpienaar13)
|
@JelleAalbers @DCichon we have been using the 98% version in the Low-ER analysis. I tend to agree with Jelle and think the default version of the cut should probably be the 98% acceptance one |
|
I agree on using the 98% version |
Renamed both versions of the cut to explicitly stress, that the 98% target acceptance version is supposed to be the main version of the cut.
|
Cuts have been renamed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated SR2 cut definition after update of preselection and added a 98% target acceptance version. See xenon:xenon1t:analysis:sciencerun2:cs2_aft_presel_update for more details.