Skip to content
This repository has been archived by the owner on Jun 5, 2024. It is now read-only.

Change WFSim SR1 photoionization file format since pkl is banned #411

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

shenyangshi
Copy link
Contributor

@shenyangshi shenyangshi commented May 17, 2023

To use the file format in https://github.com/XENONnT/private_nt_aux_files/pull/256, change the load_resource from pkl to dill. Merge this after https://github.com/XENONnT/private_nt_aux_files/pull/256 is merged,

@shenyangshi shenyangshi requested a review from ramirezdiego May 17, 2023 16:05
@shenyangshi shenyangshi marked this pull request as ready for review May 17, 2023 16:07
@shenyangshi shenyangshi changed the title Change WFSim SR1 photoionization file fotmat since pkl is banned Change WFSim SR1 photoionization file format since pkl is banned May 17, 2023
@coveralls
Copy link

coveralls commented May 17, 2023

Coverage Status

coverage: 82.605% (+0.2%) from 82.414% when pulling 9dc06ad on photoionization into e13a6ab on master.

Copy link
Collaborator

@ramirezdiego ramirezdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @shenyangshi. I approve based on the discussion in https://github.com/XENONnT/private_nt_aux_files/pull/256 (to be approved after running the simulation with this new input file).

@ramirezdiego ramirezdiego merged commit 026f910 into master Sep 7, 2023
@ramirezdiego ramirezdiego deleted the photoionization branch September 7, 2023 12:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants