Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unused needs_reinit parameters to ignored parameters #230

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

hammannr
Copy link
Collaborator

This is another tiny PR to improve the template caching behavior.

So far, we specify all shape and index parameters that are not used by a source in the dont_hash_settings. However, wit this we're missing shape parameters such as the WIMP mass, which is usually implemented as a needs_reinit parameter. By including it now we can reduce the number of duplicated cached histograms.

@hammannr hammannr requested a review from dachengx October 14, 2024 15:01
@coveralls
Copy link

coveralls commented Oct 14, 2024

Pull Request Test Coverage Report for Build 11330152405

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.632%

Totals Coverage Status
Change from base Build 11316426471: 0.0%
Covered Lines: 1703
Relevant Lines: 1900

💛 - Coveralls

@hammannr hammannr merged commit c20a399 into main Oct 15, 2024
6 of 7 checks passed
@hammannr hammannr deleted the dont_hash_needs_reinit branch October 15, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants