Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change example filename extension #93

Merged
merged 7 commits into from
Jan 5, 2024
Merged

Change example filename extension #93

merged 7 commits into from
Jan 5, 2024

Conversation

kdund
Copy link
Collaborator

@kdund kdund commented Sep 28, 2023

We found that some people did not realise that inference_interface was the way to look at files, templates etc.
In an effort to make it clearer, I thought we might change filenames to .ii.h5 (not mandatory, of course, filenames can be anything)
Also I added an exclude so the flake8 will not enforce line length in .rst files for example :)

@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Pull Request Test Coverage Report for Build 6338939120

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.741%

Totals Coverage Status
Change from base Build 6284754830: 0.0%
Covered Lines: 1333
Relevant Lines: 1453

💛 - Coveralls

@kdund kdund requested a review from hammannr October 3, 2023 14:57
Copy link
Collaborator

@hammannr hammannr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kdund ! And the paragraph in the documentation is very helpful I think 😊 .
I found two more occurrences of .h5 in the 3_sensitivity.ipynb notebook and the defaults of the Runner class. It probably makes sense to also replace those.

Copy link
Collaborator

@hammannr hammannr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prfect, thanks! 😊 I'll merge this now so that we can merge #127 afterward

@hammannr hammannr merged commit 4e8b800 into main Jan 5, 2024
7 checks passed
@hammannr hammannr deleted the filename_update branch January 5, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants