-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change example filename extension #93
Conversation
Pull Request Test Coverage Report for Build 6338939120
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @kdund ! And the paragraph in the documentation is very helpful I think 😊 .
I found two more occurrences of .h5 in the 3_sensitivity.ipynb notebook and the defaults of the Runner class. It probably makes sense to also replace those.
# Conflicts: # docs/source/basics/runner.rst
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prfect, thanks! 😊 I'll merge this now so that we can merge #127 afterward
We found that some people did not realise that inference_interface was the way to look at files, templates etc.
In an effort to make it clearer, I thought we might change filenames to .ii.h5 (not mandatory, of course, filenames can be anything)
Also I added an exclude so the flake8 will not enforce line length in .rst files for example :)