Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic-simplified ER microphysics modeling #155

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Magic-simplified ER microphysics modeling #155

wants to merge 14 commits into from

Conversation

FaroutYLq
Copy link
Contributor

@FaroutYLq FaroutYLq commented Mar 22, 2024

Not sure this is the right place to do this PR. Anyway this PR provides alternative way to simulate ER microphysics, for which the physics behind is beyond the scope of this repo (notes here). Compared to traditional ER simulation, with less parameter it is way easier to converge MCMC, maybe at the cost of lower generality which is arguably small.

@FaroutYLq FaroutYLq added the physics This PR mainly deals with physics label Mar 22, 2024
@coveralls
Copy link

coveralls commented Mar 22, 2024

Pull Request Test Coverage Report for Build 8587322966

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 34 of 51 (66.67%) changed or added relevant lines in 3 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.6%) to 84.646%

Changes Missing Coverage Covered Lines Changed/Added Lines %
appletree/components/er.py 4 11 36.36%
appletree/plugins/er_sr_microphys.py 28 38 73.68%
Files with Coverage Reduction New Missed Lines %
appletree/plugins/er_microphys.py 4 94.12%
appletree/context.py 11 91.3%
Totals Coverage Status
Change from base Build 8317691451: -0.6%
Covered Lines: 2321
Relevant Lines: 2742

💛 - Coveralls

@FaroutYLq FaroutYLq requested a review from zihaoxu98 March 23, 2024 20:19
@FaroutYLq FaroutYLq marked this pull request as draft March 23, 2024 23:13
@FaroutYLq
Copy link
Contributor Author

Will put this back once the physics is presented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physics This PR mainly deals with physics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants