Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efield position dependence #188

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Add efield position dependence #188

wants to merge 8 commits into from

Conversation

mhliu0001
Copy link
Contributor

Previously, only one uniform electric field was used. This PR adds position dependence to the electric field.

Another change is that I have unified the nestv2 parameter name with the other yield models. The field parameter was called "literature_field" before, and we should change it to "field" to avoid confusion.

@mhliu0001 mhliu0001 requested a review from dachengx September 29, 2024 16:16
@mhliu0001 mhliu0001 marked this pull request as draft September 29, 2024 16:16
@mhliu0001
Copy link
Contributor Author

I need to write a test for the field dependence.

@coveralls
Copy link

coveralls commented Sep 29, 2024

Pull Request Test Coverage Report for Build 11095259874

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 85.347%

Totals Coverage Status
Change from base Build 10709265769: 0.2%
Covered Lines: 2458
Relevant Lines: 2880

💛 - Coveralls

@mhliu0001 mhliu0001 marked this pull request as ready for review September 29, 2024 19:13
@mhliu0001 mhliu0001 requested a review from zihaoxu98 September 29, 2024 19:14
@dachengx
Copy link
Collaborator

dachengx commented Oct 1, 2024

LGTM

  1. We will need to change parameters["field"] in https://github.com/XENONnT/applefiles accordingly.
  2. This PR is not for production in SR1. So it is not in a hurry to merge it now.

Copy link
Collaborator

@dachengx dachengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants