Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backup URL to scada #1115

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Added backup URL to scada #1115

wants to merge 3 commits into from

Conversation

WenzDaniel
Copy link
Collaborator

What does the code in this PR do / what does it improve?

Add backup url to SCADA. Requires a change of our config file, should be backwards compatible.

Copy link
Contributor

@jmosbacher jmosbacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this implementation is fine but if you feel like making some improvements I would:

  1. use the base URL of the current sclogin_url as a default value so old configs still work
  2. instead of having a url and backup_url configs, just parse the url (or base_url) config as a list with url.split(',') so that multiple URLs can be passed similar to the mongo url syntax
  3. just do a for loop over the URL list and break on the first one that succeeds during login, then set the url to that one.

@ahiguera-mx
Copy link
Contributor

@LuisSanchez25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants