Remove CMT URLs #1235
Remove CMT URLs #1235
Conversation
jmosbacher
commented
Aug 11, 2023
jmosbacher
commented
- Replace all CMT URLs with xedoc URLs
- unify "cmt_version" and "xedocs_version" arguments in the context functions, replace with single "global_version" argument which loads configs from xedocs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@LuisSanchez25 is this PR important for migrating from CMT to xedocs? |
|
Depends what you mean by it. This PR mainly changes the default values is straxen, which are rarely used anyways, so it should not affect the processing of things, however, to transition to xedocs fully this is something that should be done eventually but its not immediately necessary. The main issue I believe is that there are some tests that are designed around CMT that we need to rewrite to work with xedocs. I will ask @Ananthu-Ravindran if he thinks he could work on this. |
|
Let me also remind you that @PeterGy offers his help for xedocs-related business. This is good way to start |
|
It seems the logs for what tests fail have been deleted due to lack of retention (the tests were ran back in April). It would be useful to rerun them to see where and how they fail. Unfortunately, I do not seem to have permission to rerun any tests on this repo. |
One the conflicts are squashed we can make this into a PR instead of a draft PR, then the tests will run automatically |
Add "import straxen" to peak_positions_mlp to stop tests from failing because of it using straxen.URLConfig
remove_cmt_urls
…to remove_cmt_urls
remove_cmt_urls
for more information, see https://pre-commit.ci
…to remove_cmt_urls
