Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TBRv3 library issues #104
Fix TBRv3 library issues #104
Changes from 24 commits
d78c63e
f7a157a
3825f94
2452e25
de5325b
e266e45
a9be8cb
825b498
fab59ac
0b01590
601586b
992ed99
876bf4b
5857b79
7a94091
715ad8b
a10709d
8d17070
d0ae704
c6d5542
0a11ecd
8fae0ea
6802424
10fca2d
1682022
68dcb11
9def226
13af2bc
a33532f
b2e862d
90c4abd
e27493a
23c1904
67f4575
d3e78bf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's all this about? This does not exactly fit the theme of the repo name of "arbitrary-token-transfers", no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nonergodic It is funny because I asked the same question. They want this restriction to prevent users from bridging useless tokens. By default is inactive and I believe that this feature will only be used in Portal Bridge UI.
@solanoepalacio can give you more default about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds to me that a deny list would be more desirable in that case 🤔. But I'm not sure. I'll ask.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes that shed a -little- bit of light to this.
There's two limitations that prevent to fully embracing the "arbitrary token transfers" nature of this protocol:
For this reason, there's a "phased" plan to get to Automatic Token Transfers. Plan is like so IIRC: