Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug on the realization path of printf function #4

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

wanermian
Copy link

1、modify the store address in fputc function.
2、modify the PMA of the store address to Strong Order according to smart testbench.
3、remove the redefine of printc under clib directory.

@wanermian wanermian changed the title fix bug on the realization path printf fix bug on the realization path of printf function Nov 8, 2021
@mp-17
Copy link

mp-17 commented Nov 8, 2021

Reference issue: #2
I am not sure that the sysmap.h should be the same of the C910, maybe it was different for a reason?
As a patch, it is also possible to do the following:

  1. If you just need to have a working printf, change this address and this address to 0x90000000.
  2. To avoid possible errors with custom programs, remove this file.

@wanermian wanermian closed this Nov 9, 2021
@wanermian
Copy link
Author

Reference issue: #2 I am not sure that the sysmap.h should be the same of the C910, maybe it was different for a reason? As a patch, it is also possible to do the following:

  1. If you just need to have a working printf, change this address and this address to 0x90000000.
  2. To avoid possible errors with custom programs, remove this file.

The SoC demo of C906 is similar to C910. In addition, address 0x9000_0000 falls in the ERR2 interval which may results in bus error.

@wanermian wanermian reopened this Nov 9, 2021
@mp-17
Copy link

mp-17 commented Nov 9, 2021

Agree, I used 0x90000000 since no errors were thrown. If there was no reason for the initial choice of sysmap.h, it's fine. Thanks for the PR! :-)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


unknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants