Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes for net5 tfm #2103

Closed
sungam3r opened this issue Dec 3, 2023 · 7 comments · Fixed by #2112
Closed

Revert changes for net5 tfm #2103

sungam3r opened this issue Dec 3, 2023 · 7 comments · Fixed by #2112
Assignees
Milestone

Comments

@sungam3r
Copy link
Collaborator

sungam3r commented Dec 3, 2023

          > for some projects I've removed net5.0 tfm as it's [not supported anymore](https://dotnet.microsoft.com/en-us/platform/support/policy/dotnet-core)

изображение

It should be reverted. It make no sence to require higher TFM in case no specific APIs are used from that TFM. Yes, net5 not supported anymore but this is story about runtime/end-applications but not about libraries. With such change as at picture above you make impossible for net5 apps to use this health check though healthcheck itself works perfectly targeted for net5.

Originally posted by @sungam3r in #2044 (comment)

@sungam3r sungam3r added this to the V 8.0 milestone Dec 3, 2023
@sungam3r
Copy link
Collaborator Author

sungam3r commented Dec 3, 2023

ping @adamsitnik

@adamsitnik
Copy link
Collaborator

With such change as at picture above you make impossible for net5 apps to use this health check though healthcheck itself works perfectly targeted for net5.

But it's still targeting netstandard2.0, so .NET 5, .NET Core 3.1 and even 2.1 apps can still use it.

@sungam3r
Copy link
Collaborator Author

sungam3r commented Dec 4, 2023

@sungam3r
Copy link
Collaborator Author

sungam3r commented Dec 4, 2023

One should not bump tfm requirements just because.

adamsitnik added a commit to adamsitnik/AspNetCore.Diagnostics.HealthChecks that referenced this issue Dec 4, 2023
@adamsitnik adamsitnik self-assigned this Dec 4, 2023
@adamsitnik
Copy link
Collaborator

Look

Thanks for pointing that out! 👍

One should not bump tfm requirements just because.

If we follow the .NET release schedule and use the same major version numbers, when should we drop non-supported TFMs?

@sungam3r
Copy link
Collaborator Author

sungam3r commented Dec 4, 2023

No

@sungam3r
Copy link
Collaborator Author

sungam3r commented Dec 4, 2023

"Not supported" is not applicable from api-set point of view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants