Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert the removal of net5.0 moniker #2112

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Conversation

adamsitnik
Copy link
Collaborator

@adamsitnik adamsitnik commented Dec 4, 2023

fixes #2103

@adamsitnik adamsitnik added this to the V 8.0 milestone Dec 4, 2023
@adamsitnik adamsitnik changed the title revert the removal of net5.0 moniker, fixes #2103 revert the removal of net5.0 moniker Dec 4, 2023
@github-actions github-actions bot added the uris label Dec 4, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81c6697) 64.94% compared to head (378fa37) 64.31%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2112      +/-   ##
==========================================
- Coverage   64.94%   64.31%   -0.64%     
==========================================
  Files         262      246      -16     
  Lines        8496     8312     -184     
  Branches      600      578      -22     
==========================================
- Hits         5518     5346     -172     
+ Misses       2828     2822       -6     
+ Partials      150      144       -6     
Flag Coverage Δ
AzureBlobStorage ?
AzureEventHubs ?
AzureFileStorage ?
AzureQueueStorage ?
AzureTableStorage ?
Dapr ?
Uris 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungam3r
Copy link
Collaborator

sungam3r commented Dec 4, 2023

Was it single project?

Copy link
Collaborator

@sungam3r sungam3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that only change you did when removing net5?

@adamsitnik
Copy link
Collaborator Author

Great question! I've searched for usages of #if and found one more project that required the change (HealthChecks.Network)

@adamsitnik adamsitnik merged commit fb04fe8 into Xabaril:master Dec 6, 2023
3 checks passed
@adamsitnik adamsitnik deleted the issue2103 branch December 6, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert changes for net5 tfm
3 participants