Update to .NET 8 RTM #2097

adamsitnik · 2023-11-23T17:42:06Z

all samples got updated to .NET 8
all dependencies got updated to latest versions
breaking changes got fixed (or worked around)

Some tests are failing, but I believe that these are simply unstable/noisy.

… in Test projects

… and removed (it was unused), see rabbitmq/rabbitmq-dotnet-client#846 for more details

…tions, as they can cause deadlocks.

…extension type since it remains in the same namespace, it should not break the users (they typically don't type full type name that provides the extensions)

adamsitnik · 2023-11-23T17:53:40Z

test/HealthChecks.ApplicationStatus.Tests/Functional/ApplicationStatusHealthCheckTests.cs

@@ -6,7 +6,7 @@ public class applicationstatus_healthcheck_should
    public async Task be_healthy_if_application_is_not_stopped()
    {
        using var sut = new ApplicationStatusHealthCheck(new TestHostApplicationLifeTime());
-        var result = await sut.CheckHealthAsync(new HealthCheckContext()).ConfigureAwait(false);
+        var result = await sut.CheckHealthAsync(new HealthCheckContext());


fix xUnit1030 in the whole solution: don't use .GetAwaiter in Test projects

It could be a part of another PR but I'm fine to review all these changes in single PR.

adamsitnik · 2023-11-23T17:57:05Z

test/HealthChecks.SqlServer.Tests/DependencyInjection/RegistrationTests.cs

@@ -42,7 +42,7 @@ void beforeOpen(SqlConnection connection)
        var registration = options.Value.Registrations.First();
        var check = registration.Factory(serviceProvider);

-        Record.ExceptionAsync(() => check.CheckHealthAsync(new HealthCheckContext())).GetAwaiter().GetResult();
+        await Record.ExceptionAsync(() => check.CheckHealthAsync(new HealthCheckContext()));


xUnit1031: Test methods should not use blocking task operations, as they can cause deadlocks.

…on does not support EF Core 8.0

… hangs)

.github/workflows/healthchecks_influxdb_ci.yml

sungam3r · 2023-12-03T20:37:55Z

Ooops, I did not see this one when making changes in #2104. Sorry.

# Conflicts: # build/docker-images/HealthChecks.UI.Image/HealthChecks.UI.Image.csproj # src/HealthChecks.Aws.S3/HealthChecks.Aws.S3.csproj # src/HealthChecks.Aws.SecretsManager/HealthChecks.Aws.SecretsManager.csproj # src/HealthChecks.Aws.Sns/HealthChecks.Aws.Sns.csproj # src/HealthChecks.Aws.Sqs/HealthChecks.Aws.Sqs.csproj # src/HealthChecks.Aws.SystemsManager/HealthChecks.Aws.SystemsManager.csproj # src/HealthChecks.Azure.Data.Tables/HealthChecks.Azure.Data.Tables.csproj # src/HealthChecks.Azure.Messaging.EventHubs/HealthChecks.Azure.Messaging.EventHubs.csproj # src/HealthChecks.Azure.Storage.Blobs/HealthChecks.Azure.Storage.Blobs.csproj # src/HealthChecks.Azure.Storage.Files.Shares/HealthChecks.Azure.Storage.Files.Shares.csproj # src/HealthChecks.Azure.Storage.Queues/HealthChecks.Azure.Storage.Queues.csproj # src/HealthChecks.AzureSearch/HealthChecks.AzureSearch.csproj # src/HealthChecks.AzureServiceBus/HealthChecks.AzureServiceBus.csproj # src/HealthChecks.CosmosDb/HealthChecks.CosmosDb.csproj # src/HealthChecks.Dapr/HealthChecks.Dapr.csproj # src/HealthChecks.DynamoDb/HealthChecks.DynamoDb.csproj # src/HealthChecks.Gcp.CloudFirestore/HealthChecks.Gcp.CloudFirestore.csproj # src/HealthChecks.Hangfire/HealthChecks.Hangfire.csproj # src/HealthChecks.IbmMQ/HealthChecks.IbmMQ.csproj # src/HealthChecks.InfluxDB/HealthChecks.InfluxDB.csproj # src/HealthChecks.Kafka/HealthChecks.Kafka.csproj # src/HealthChecks.Kubernetes/HealthChecks.Kubernetes.csproj # src/HealthChecks.MongoDb/HealthChecks.MongoDb.csproj # src/HealthChecks.MySql/HealthChecks.MySql.csproj # src/HealthChecks.Nats/HealthChecks.Nats.csproj # src/HealthChecks.NpgSql/HealthChecks.NpgSql.csproj # src/HealthChecks.Oracle/HealthChecks.Oracle.csproj # src/HealthChecks.Publisher.CloudWatch/HealthChecks.Publisher.CloudWatch.csproj # src/HealthChecks.Publisher.Prometheus/HealthChecks.Publisher.Prometheus.csproj # src/HealthChecks.Rabbitmq/HealthChecks.Rabbitmq.csproj # src/HealthChecks.RavenDB/HealthChecks.RavenDB.csproj # src/HealthChecks.Redis/HealthChecks.Redis.csproj # src/HealthChecks.SignalR/HealthChecks.SignalR.csproj # src/HealthChecks.UI.K8s.Operator/HealthChecks.UI.K8s.Operator.csproj # src/HealthChecks.UI/HealthChecks.UI.csproj # test/HealthChecks.Azure.Messaging.EventHubs.Tests/HealthChecks.Azure.Messaging.EventHubs.Tests.csproj # test/HealthChecks.AzureDigitalTwin.Tests/HealthChecks.AzureDigitalTwin.Tests.csproj # test/HealthChecks.AzureServiceBus.Tests/HealthChecks.AzureServiceBus.Tests.csproj # test/HealthChecks.UI.Client.Tests/HealthChecks.UI.Client.Tests.csproj # test/HealthChecks.UI.Data.Tests/HealthChecks.UI.Data.Tests.csproj # test/HealthChecks.UI.Tests/HealthChecks.UI.Tests.csproj

…ing the extension type" This reverts commit 948072c.

This reverts commit accb278.

adamsitnik · 2023-12-04T07:24:52Z

Ooops, I did not see this one when making changes in #2104. Sorry.

@sungam3r I've solved the merge conflict, could you please review this PR?

src/HealthChecks.NpgSql/HealthChecks.NpgSql.csproj

# Conflicts: # Directory.Build.props

codecov-commenter · 2023-12-04T09:00:46Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (cb4b321) 66.80% compared to head (d12ef0d) 65.48%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
src/HealthChecks.UI/Core/UIResourceMapper.cs	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
- Coverage   66.80%   65.48%   -1.32%     
==========================================
  Files         254      270      +16     
  Lines        8591     8774     +183     
  Branches      612      634      +22     
==========================================
+ Hits         5739     5746       +7     
- Misses       2693     2868     +175     
- Partials      159      160       +1

Flag	Coverage Δ
ApplicationStatus	`26.66% <ø> (ø)`
ArangoDb	`26.50% <ø> (ø)`
Aws.S3	`14.28% <ø> (ø)`
Aws.SecretsManager	`14.54% <ø> (ø)`
Aws.Sns	`14.77% <ø> (ø)`
Aws.Sqs	`15.28% <ø> (ø)`
Aws.SystemsManager	`14.54% <ø> (ø)`
Azure.IoTHub	`12.82% <ø> (ø)`
AzureApplicationInsights	`14.70% <ø> (ø)`
AzureBlobStorage	`25.17% <ø> (?)`
AzureDigitalTwin	`35.76% <ø> (ø)`
AzureEventHubs	`16.54% <ø> (?)`
AzureFileStorage	`25.17% <ø> (?)`
AzureKeyVault	`29.24% <ø> (ø)`
AzureQueueStorage	`25.17% <ø> (?)`
AzureSearch	`16.10% <ø> (ø)`
AzureServiceBus	`71.34% <ø> (ø)`
AzureTableStorage	`26.66% <ø> (?)`
Consul	`22.58% <ø> (ø)`
CosmosDb	`28.10% <ø> (ø)`
Dapr	`14.50% <ø> (?)`
DocumentDb	`14.64% <ø> (ø)`
DynamoDb	`12.12% <ø> (ø)`
Elasticsearch	`39.49% <ø> (ø)`
EventStore	`62.08% <ø> (ø)`
EventStore.gRPC	`25.51% <ø> (ø)`
Gcp.CloudFirestore	`12.10% <ø> (ø)`
Gremlin	`23.07% <ø> (ø)`
Hangfire	`10.97% <ø> (ø)`
IbmMQ	`30.76% <ø> (ø)`
InfluxDB	`15.00% <ø> (ø)`
Kafka	`22.03% <ø> (ø)`
Kubernetes	`41.54% <ø> (ø)`
MongoDb	`28.86% <ø> (ø)`
MySql	`33.33% <ø> (ø)`
Nats	`69.85% <ø> (ø)`
Npgsql	`41.28% <ø> (ø)`
OpenIdConnectServer	`39.28% <ø> (ø)`
Oracle	`60.60% <ø> (ø)`
Prometheus.Metrics	`29.80% <ø> (ø)`
Publisher.ApplicationInsights	`14.76% <ø> (ø)`
Publisher.CloudWatch	`19.02% <ø> (ø)`
Publisher.Datadog	`15.00% <ø> (ø)`
Publisher.Prometheus	`18.75% <ø> (ø)`
Publisher.Seq	`40.30% <ø> (ø)`
RabbitMQ	`47.67% <100.00%> (-0.22%)`	⬇️
RavenDb	`70.74% <ø> (ø)`
Redis	`65.71% <ø> (ø)`
SendGrid	`11.92% <ø> (ø)`
SignalR	`24.22% <ø> (ø)`
SqlServer	`28.57% <ø> (ø)`
Sqlite	`26.38% <ø> (ø)`
System	`37.28% <ø> (ø)`
UI	`65.84% <50.00%> (-0.12%)`	⬇️
Uris	`0.00% <ø> (-61.87%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/HealthChecks.RavenDb.Tests/Functional/RavenDbHealthCheckTests.cs

sungam3r · 2023-12-04T09:24:31Z

Almost reviewed, one more conflict left.

adamsitnik · 2023-12-04T09:35:25Z

Almost reviewed, one more conflict left.

@sungam3r Thanks a lot! I've pushed changes to resolve the conflict

adamsitnik added 8 commits November 23, 2023 17:29

update all dependencies that don't require TFM update to latest versions

945b745

build fix: fix xUnit1030 in the whole solution: don't use .GetAwaiter…

caa75b5

… in Test projects

build fix: stop using UseBackgroundThreadsForIO, which got deprecated…

8b35098

… and removed (it was unused), see rabbitmq/rabbitmq-dotnet-client#846 for more details

build fix: xUnit1031: Test methods should not use blocking task opera…

28715c0

…tions, as they can cause deadlocks.

update all dependencies that required TFM bump to .NET 85

7f20b8b

build fix: stop using .Add, use .Append instead

262e670

build fix: workaround a naming conflict with ASP.NET by renaming the …

948072c

…extension type since it remains in the same namespace, it should not break the users (they typically don't type full type name that provides the extensions)

update Oracle client for .NET Standard 2.1

5bc076e

github-actions bot added UI arrangodb test kafka aws azure consul mysql rabbitmq ravendb redis influxdb npgsql kubernetes mongodb sqlite samples signalr dynamodb elasticsearch applicationstatus cosmosdb labels Nov 23, 2023

adamsitnik commented Nov 23, 2023

View reviewed changes

adamsitnik added 5 commits November 23, 2023 19:24

trying to fix the tests by increasing or decreasing the timeouts

75c5eff

update Pomelo.EntityFrameworkCore.MySql to 8.0.0-beta.2, as 7.0 versi…

ceb153c

…on does not support EF Core 8.0

revert SqlServer changes

3f17483

try use specific Influx db version to fix the CI (currently the setup…

8b37491

… hangs)

run approval tests for 8, not 7

a50abf2

adamsitnik commented Nov 23, 2023

View reviewed changes

.github/workflows/healthchecks_influxdb_ci.yml Outdated Show resolved Hide resolved

adamsitnik added 2 commits November 23, 2023 20:35

update approved

accb278

add a workaround for dotnet/SqlClient#1930

3caee6c

adamsitnik mentioned this pull request Nov 23, 2023

Hanging with no output influxdata/influxdb-action#5

Open

adamsitnik requested a review from unaizorrilla November 23, 2023 20:12

adamsitnik added 4 commits December 4, 2023 07:45

Revert "build fix: workaround a naming conflict with ASP.NET by renam…

9ece49d

…ing the extension type" This reverts commit 948072c.

Revert "update approved"

42200ed

This reverts commit accb278.

build fix

883033c

adamsitnik requested a review from sungam3r December 4, 2023 07:23

sungam3r reviewed Dec 4, 2023

View reviewed changes

src/HealthChecks.NpgSql/HealthChecks.NpgSql.csproj Show resolved Hide resolved

adamsitnik added 2 commits December 4, 2023 09:51

address code review feedback

d12ef0d

Merge remote-tracking branch 'upstream/master' into net80rtm

edcd670

# Conflicts: # Directory.Build.props

sungam3r reviewed Dec 4, 2023

View reviewed changes

test/HealthChecks.RavenDb.Tests/Functional/RavenDbHealthCheckTests.cs Show resolved Hide resolved

sungam3r approved these changes Dec 4, 2023

View reviewed changes

adamsitnik merged commit 81c6697 into Xabaril:master Dec 4, 2023
59 checks passed

adamsitnik deleted the net80rtm branch December 4, 2023 09:43

adamsitnik mentioned this pull request Feb 28, 2024

V 8.0 Release #1967

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to .NET 8 RTM #2097

Update to .NET 8 RTM #2097

adamsitnik commented Nov 23, 2023 •

edited

Loading

adamsitnik Nov 23, 2023

sungam3r Dec 4, 2023

adamsitnik Nov 23, 2023

sungam3r commented Dec 3, 2023

adamsitnik commented Dec 4, 2023

codecov-commenter commented Dec 4, 2023

sungam3r commented Dec 4, 2023

adamsitnik commented Dec 4, 2023

Update to .NET 8 RTM #2097

Update to .NET 8 RTM #2097

Conversation

adamsitnik commented Nov 23, 2023 • edited Loading

adamsitnik Nov 23, 2023

Choose a reason for hiding this comment

sungam3r Dec 4, 2023

Choose a reason for hiding this comment

adamsitnik Nov 23, 2023

Choose a reason for hiding this comment

sungam3r commented Dec 3, 2023

adamsitnik commented Dec 4, 2023

codecov-commenter commented Dec 4, 2023

Codecov Report

sungam3r commented Dec 4, 2023

adamsitnik commented Dec 4, 2023

adamsitnik commented Nov 23, 2023 •

edited

Loading