Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RabbitMQ connection leaks #2153

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Fix RabbitMQ connection leaks #2153

merged 3 commits into from
Aug 29, 2024

Conversation

sungam3r
Copy link
Collaborator

@sungam3r sungam3r commented Feb 2, 2024

fixes #2048

See with this option enabled
изображение

@unaizorrilla
Copy link
Collaborator

unaizorrilla commented Mar 30, 2024

Hi @sungam3r

LGTM but Can you also upgrade the package version on the pr?

@Jamie-Clayton Jamie-Clayton mentioned this pull request Jun 21, 2024
@Alirexaa Alirexaa added this to the V 8.1 milestone Jun 22, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.30435% with 6 lines in your changes missing coverage. Please review.

Project coverage is 64.42%. Comparing base (fb04fe8) to head (706fcd4).
Report is 26 commits behind head on master.

Files Patch % Lines
...yInjection/RabbitMQHealthCheckBuilderExtensions.cs 92.53% 2 Missing and 3 partials ⚠️
src/HealthChecks.Rabbitmq/RabbitMQHealthCheck.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2153       +/-   ##
===========================================
+ Coverage    0.00%   64.42%   +64.42%     
===========================================
  Files           7      248      +241     
  Lines         356     8368     +8012     
  Branches       28      586      +558     
===========================================
+ Hits            0     5391     +5391     
- Misses        356     2830     +2474     
- Partials        0      147      +147     
Flag Coverage Δ
RabbitMQ 48.76% <91.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Alirexaa Alirexaa merged commit 9fc08fc into master Aug 29, 2024
2 checks passed
@Alirexaa Alirexaa deleted the rmq branch August 29, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants