Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Storage Accounts PoLP (Principle of least privilege) Approach #2284

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Qualizorg
Copy link

Here's the completed PR template for your draft pull request:


What this PR does / why we need it:

This PR modifies the health checks for Azure Storage Account (blob, queue, and table storage) to work with a least privilege approach. Previously, the health checks required roles at the storage account level, which caused failures when permissions were assigned at the resource level (e.g., tables, queues, containers) via RBAC. The new implementation allows health checks to be performed with roles assigned at the specific resource level, adhering to the principle of least privilege.

Which issue(s) this PR fixes:
None that I'm aware of.

Special notes for your reviewer:

  • The health check methods have been updated to handle permissions at the resource level correctly.
  • Comments have been added to explain the rationale behind the changes and to provide guidance on required roles.

Does this PR introduce a user-facing change?:

No, this PR does not introduce a user-facing change.

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Unit tests passing
  • End-to-end tests passing
  • Extended the documentation
  • Provided sample for the feature

@Qualizorg
Copy link
Author

@dotnet-policy-service agree company="Qualizorg B.V"

@Qualizorg
Copy link
Author

@dotnet-policy-service agree company="Qualizorg B.V"

@xInfinitYz
Copy link

Can we merge this?

@Qualizorg
Copy link
Author

@Alirexaa Could we push this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants