Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign HealthChecks.MongoDb #2291

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Sign HealthChecks.MongoDb #2291

merged 1 commit into from
Aug 29, 2024

Conversation

eerhardt
Copy link
Collaborator

We can sign this assembly now because MongoDB.Driver is now signed as of v2.28.

We can sign this assembly now because MongoDB.Driver is now signed as of v2.28.
@Alirexaa
Copy link
Collaborator

I remember that I removed <SignAssembly>false</SignAssembly> from HealthChecks.MongoDb in #2266.
I checked this and noticed that I removed <SignAssembly>false</SignAssembly> from HealthChecks.UI instead of HealthChecks.MongoDb and it's wrong.
Should we revert this removal from HealthChecks.UI or can we sign HealthChecks.UI too?
cc @adamsitnik

Copy link
Collaborator

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @eerhardt !

@adamsitnik adamsitnik merged commit f8128d8 into master Aug 29, 2024
3 checks passed
@adamsitnik adamsitnik deleted the eerhardt-patch-1 branch August 29, 2024 12:57
@adamsitnik
Copy link
Collaborator

Should we revert this removal from HealthChecks.UI or can we sign HealthChecks.UI too?

I don't have a strong opinion, for now we can keep it signed and see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants