-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fock to bargmann #457
Merged
Merged
Fock to bargmann #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apchytr
reviewed
Aug 21, 2024
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Filippo Miatto <[email protected]>
Co-authored-by: Anthony <[email protected]>
apchytr
reviewed
Aug 21, 2024
Co-authored-by: Anthony <[email protected]>
apchytr
reviewed
Aug 21, 2024
ziofil
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's gooooo
ziofil
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's gooooo
apchytr
reviewed
Aug 22, 2024
Co-authored-by: Anthony <[email protected]>
apchytr
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Adding a method to convert circuit components from Fock to Bargmann
Description of the Change:
When contracting a bargmann and a fock object with each other, the fock object is converted to bargmann. This is opposite of what is currently done. If two fock objects meet each other they stay in fock.
Benefits:
Number.dual
as a measurement device).Possible Drawbacks:
Related GitHub Issues: