-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase min cutoff for visualize2d/3d to 50 #463
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #463 +/- ##
===========================================
+ Coverage 89.21% 89.22% +0.01%
===========================================
Files 102 102
Lines 7194 7201 +7
===========================================
+ Hits 6418 6425 +7
Misses 776 776
Continue to review full report in Codecov by Sentry.
|
Co-authored-by: Matthew Silverman <[email protected]>
i can't speak to whether there are cases where this minimum doesn't really make sense, but I am guessing you can - do any instances come to mind where we don't want this minimum, and if so, can we use the new kwarg in those cases? otherwise, this looks good to me |
We'll replace the discretized method with calling the new ansatz as soon as it's available. In the meantime this is good enough to not incur in odd results like you'd have with too small cutoff. |
Visualize2d/3d can show a wrong image when plotting non-DM wigner functions, such as the parity operator. This PR guarantees a minimum fock cutoff of 50 for the wigner plot, which solves most of these issues.
Before:
After:
Also 3d (after):