Bloch Messiah decomposition from The Walrus #729
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
===========================================
- Coverage 98.33% 38.88% -59.46%
===========================================
Files 78 78
Lines 9603 9578 -25
===========================================
- Hits 9443 3724 -5719
- Misses 160 5854 +5694
Continue to review full report at Codecov.
|
nquesada
reviewed
Sep 27, 2022
strawberryfields/decompositions.py
Outdated
| @@ -1021,53 +1011,7 @@ def bloch_messiah(S, tol=1e-10, rounding=9): | |||
| if np.linalg.norm(np.transpose(S) @ omega @ S - omega) >= tol: | |||
There was a problem hiding this comment.
there is a is_symplectic function in the walrus that you can use directly here :)
There was a problem hiding this comment.
oh! comments on unmodified lines 🧐
(thanks for the suggestion, will do!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is using thewalrus/main. DO NOT MERGE until there is a new release of The Walrus (don't forget to change the requirement files accordingly).
Context:
The current implementation of the Bloch-Messiah decomposition fails for degenerate symplectic matrices.
Description of the Change:
The Walrus included a new implementation of the Bloch-Messiah decomposition that solves the issue. This PR swaps the
SF implementation for the new improved implementation on TW.
Benefits:
Bloch-Messiah works for degenerate symplectic matrices.
Possible Drawbacks:
None.
Related GitHub Issues:
Closes #728