Skip to content

Commit

Permalink
Removes unnecesary comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Nicolas Quesada committed Jan 3, 2024
1 parent 184df59 commit 2b90999
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions thewalrus/decompositions.py
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,6 @@ def takagi(A, svd_order=True):

u, d, v = np.linalg.svd(A)
U = u @ sqrtm((v @ np.conjugate(u)).T)
# The line above could be simplifed to the line below if the product v @ np.conjugate(u) is diagonal
# Which it should be according to Caves http://info.phys.unm.edu/~caves/courses/qinfo-s17/lectures/polarsingularAutonne.pdf
# U = u * np.sqrt(0j + np.diag(v @ np.conjugate(u)))
# This however breaks test_degenerate
if svd_order is False:
return d[::-1], U[:, ::-1]
return d, U

0 comments on commit 2b90999

Please sign in to comment.