Add Godsil-Gutman estimator #392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change test calls to hafnian_approx update changelog
|
Hi, could you address this two minor issues detected by the bots: |
nquesada
reviewed
Sep 26, 2024
nquesada
reviewed
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Randomized estimators of the Hafnian of a nonnegative matrices can be implemented in two different manners. Previously
hafnian_approx()only implemented one of themDescription of the Change:
Added an option to use the Godsil-Gutman estimator. Also changed the signature of
hafnian()so that now all methods are controlled by themethodparameter, and theapproxparameter is removed as redundant.Benefits:
Possible Drawbacks:
Related GitHub Issues: