Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with the new timer recorder plugin for Chrome #390

Closed
jowerner opened this issue Jul 18, 2023 · 0 comments · Fixed by #440
Closed

Issues with the new timer recorder plugin for Chrome #390

jowerner opened this issue Jul 18, 2023 · 0 comments · Fixed by #440
Assignees
@jowerner
Labels
bug Something isn't working
Milestone
8.0.0

Comments

@jowerner
Copy link
Contributor

jowerner commented Jul 18, 2023 •
edited
Loading

There have been reports that test scenarios using XltChromeDriver show different issues now, such as:

  • higher scenario runtimes
  • higher request runtimes
  • unexpected "think times" at the end of a scenario
  • unexpected errors when quitting the driver (UnhandledAlertException: unexpected alert open: {Alert text : })

Looks as if this is related to our timer recorder plugin for Chrome. In XLT 7.0.0, we have updated it to support Chrome Manifest v3 (see #141). A cross-check with XLT 6.x showed that the new plugin causes these issues with both XLT 6 and 7, while the old plugin does not make any trouble.
@jowerner jowerner added the bug Something isn't working label Jul 18, 2023
@jowerner jowerner mentioned this issue Jul 18, 2023
Closed
@jowerner jowerner linked a pull request Nov 20, 2023 that will close this issue
#390: Issues with the new timer recorder plugin for Chrome #440
Merged
@jowerner jowerner self-assigned this Dec 1, 2023
h-arlt added a commit that referenced this issue Feb 12, 2024
@jowerner @h-arlt
#390: Issues with the new timer recorder plugin for Chrome (#440)
42ab772 
* Revert "Revert "GH #141: Timerrecorder extension: migrate to manifest v3 (#244)""

This reverts commit 7549bfa.

* small bug fixes and improvements

* temporarily use zip to pack the extension until the bug in Chrome 119 is fixed

* Chrome Timer Recorder
* upped minimum chrome version to 116 (see https://developer.chrome.com/docs/extensions/mv3/service_workers/service-worker-lifecycle/#chrome-116)
* installed a periodic task that sends a dummy message to XLT to keep the service worker alive
* made the usage of the session storage configurable (off by default)
* added a helper function to calculate the size of the request line
* minor optimizations
* added some useful logger functions

XLT
* made the usage of the session storage in the chrome timer recorder configurable (off by default)
* handle new keep-alive messages by ignoring them
* adjusted logging when receiving timer data

* feedback from reviewer

* feedback from reviewer

Co-authored-by: h-arlt <[email protected]>

* Revert "temporarily use zip to pack the extension until the bug in Chrome 119 is fixed"

This reverts commit 53d03e5.

---------

Co-authored-by: h-arlt <[email protected]>
@jowerner jowerner added this to the 8.0.0 milestone Feb 29, 2024
xceptance-dan pushed a commit to xceptance-dan/XLT that referenced this issue Apr 18, 2024
@jowerner @h-arlt
Xceptance#390: Issues with the new timer recorder plugin for Chrome (X…
727413d 
…ceptance#440)

* Revert "Revert "GH Xceptance#141: Timerrecorder extension: migrate to manifest v3 (Xceptance#244)""

This reverts commit 7549bfa.

* small bug fixes and improvements

* temporarily use zip to pack the extension until the bug in Chrome 119 is fixed

* Chrome Timer Recorder
* upped minimum chrome version to 116 (see https://developer.chrome.com/docs/extensions/mv3/service_workers/service-worker-lifecycle/#chrome-116)
* installed a periodic task that sends a dummy message to XLT to keep the service worker alive
* made the usage of the session storage configurable (off by default)
* added a helper function to calculate the size of the request line
* minor optimizations
* added some useful logger functions

XLT
* made the usage of the session storage in the chrome timer recorder configurable (off by default)
* handle new keep-alive messages by ignoring them
* adjusted logging when receiving timer data

* feedback from reviewer

* feedback from reviewer

Co-authored-by: h-arlt <[email protected]>

* Revert "temporarily use zip to pack the extension until the bug in Chrome 119 is fixed"

This reverts commit 53d03e5.

---------

Co-authored-by: h-arlt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jowerner jowerner

Labels
bug Something isn't working
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

#390: Issues with the new timer recorder plugin for Chrome Xceptance/XLT
1 participant
@jowerner