#390: Issues with the new timer recorder plugin for Chrome #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upped minimum chrome version to 116 (see https://developer.chrome.com/docs/extensions/mv3/service_workers/service-worker-lifecycle/#chrome-116) * installed a periodic task that sends a dummy message to XLT to keep the service worker alive * made the usage of the session storage configurable (off by default) * added a helper function to calculate the size of the request line * minor optimizations * added some useful logger functions XLT * made the usage of the session storage in the chrome timer recorder configurable (off by default) * handle new keep-alive messages by ignoring them * adjusted logging when receiving timer data
|
Some of the changes needs to be made for the FF timer recorder as well. Will do this when the review for the Chrome version is done. |
h-arlt
reviewed
Nov 24, 2023
src/main/java/com/xceptance/xlt/clientperformance/WebExtConnectionHandler.java
Outdated
Show resolved
Hide resolved
|
Marked this PR as draft so it won't be merged accidentally before these steps are done:
|
h-arlt
reviewed
Nov 29, 2023
h-arlt
approved these changes
Nov 29, 2023
Co-authored-by: h-arlt <[email protected]>
…rome 119 is fixed" This reverts commit 53d03e5.
To not delay the fixes for the Chrome timer recorder any further, we postpone the first point to #462. The second point is done. |
h-arlt
approved these changes
Feb 12, 2024
xceptance-dan
pushed a commit
to xceptance-dan/XLT
that referenced
this pull request
Apr 18, 2024
…ceptance#440) * Revert "Revert "GH Xceptance#141: Timerrecorder extension: migrate to manifest v3 (Xceptance#244)"" This reverts commit 7549bfa. * small bug fixes and improvements * temporarily use zip to pack the extension until the bug in Chrome 119 is fixed * Chrome Timer Recorder * upped minimum chrome version to 116 (see https://developer.chrome.com/docs/extensions/mv3/service_workers/service-worker-lifecycle/#chrome-116) * installed a periodic task that sends a dummy message to XLT to keep the service worker alive * made the usage of the session storage configurable (off by default) * added a helper function to calculate the size of the request line * minor optimizations * added some useful logger functions XLT * made the usage of the session storage in the chrome timer recorder configurable (off by default) * handle new keep-alive messages by ignoring them * adjusted logging when receiving timer data * feedback from reviewer * feedback from reviewer Co-authored-by: h-arlt <[email protected]> * Revert "temporarily use zip to pack the extension until the bug in Chrome 119 is fixed" This reverts commit 53d03e5. --------- Co-authored-by: h-arlt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome Timer Recorder
XLT