This repository has been archived by the owner on Jun 27, 2020. It is now read-only.
Fixed Xcode crash involving "completion-scope" #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allewun
force-pushed
the
aw-fix-completionscope-crash
branch
from
269f9e7 to
baed4f0
Compare
allewun
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the YAML section of a snippet doesn't define a
completion-scopekey-value pair,xcodesnippetwill assign[nil]to@snippet.completion_scopesand generate an invalid .plist, causing Xcode to crash.I've updated
xcodesnippetto only acceptcompletion-scopes(plural) and notcompletion-scope. This subtle difference was also pretty easy to miss imho. As a result, the snippets in your other repo would need to be updated to usecompletion-scopesrather thancompletion-scope.I also updated the README with the list of valid completion scopes. Hope these are reasonable changes!