Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改发送队列的tail自加位置 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qxc2016
Copy link

@qxc2016 qxc2016 commented Oct 26, 2018

按照原先的方式,会导致在发送时出错。

按照原先的方式,会导致在发送时出错。
@XeiTongXueFlyMe
Copy link
Owner

看了你提交的代码,可以具体的描述一下,出错的情况吗,方便我定位bug。
研读了你提交的代码,当J1939_OVERWRITE_TX_QUEUE 配置为J1939_TRUE时,将产生内存溢出的风险TXTail_1可能大于J1939_TX_QUEUE_SIZE

@qxc2016
Copy link
Author

qxc2016 commented Nov 20, 2018

看了你提交的代码,可以具体的描述一下,出错的情况吗,方便我定位bug。
研读了你提交的代码,当J1939_OVERWRITE_TX_QUEUE 配置为J1939_TRUE时,将产生内存溢出的风险TXTail_1可能大于J1939_TX_QUEUE_SIZE

最近出差,刚有时间回复,出错的具体情况就是,不能正常发送,因为tail没有正确加1,导致发送刷新函数的判断里,判断不到有发送队列。我应该没有修改J1939_OVERWRITE_TX_QUEUE 这个宏定义吧?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants